Skip to content

feat(eslint-plugin-query): add Suspense query hooks to no-rest-destructuring rule #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TkDodo merged 2 commits into from
Nov 8, 2024
Merged

feat(eslint-plugin-query): add Suspense query hooks to no-rest-destructuring rule #8260

TkDodo merged 2 commits into from
Nov 8, 2024

Conversation

@gyumong
Copy link
Contributor

@gyumong gyumong commented Nov 7, 2024

This PR adds 'useSuspenseQuery' , 'useSuspenseQueries' and 'useSuspenseInfiniteQuery' to the queryHooks array in the no-rest-destructuring ESLint rule.

issue: #8231

@nx-cloud
Copy link

nx-cloud bot commented Nov 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f35dc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8260

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8260

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8260

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8260

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8260

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8260

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8260

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8260

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8260

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8260

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8260

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8260

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8260

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8260

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8260

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8260

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8260

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8260

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8260

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8260

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8260

commit: 8f35dc6

@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (2fe16e5) to head (8f35dc6).
Report is 63 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8260       +/-   ##
===========================================
+ Coverage   45.41%   88.32%   +42.91%     
===========================================
  Files         200       15      -185     
  Lines        7456      497     -6959     
  Branches     1696      186     -1510     
===========================================
- Hits         3386      439     -2947     
+ Misses       3694       44     -3650     
+ Partials      376       14      -362
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.32% <100.00%> (+0.50%) ⬆️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 2f6c028 into TanStack:main Nov 8, 2024
8 checks passed
@gyumong gyumong deleted the fix/lint-no-rest-destructurin branch November 8, 2024 10:21
@SimenB
Copy link
Contributor

SimenB commented Nov 8, 2024

Thanks! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gyumong @SimenB @TkDodo