Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4c40c12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
manudeli
commented
Nov 15, 2024
Comment on lines
71
to
73
| export function noop(): undefined { | ||
| return undefined | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
unified this noop return type from undefined to void
Collaborator
Author
There was a problem hiding this comment.
Now @tanstack/query-core's noop's return type is undefined
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8294 +/- ##
===========================================
+ Coverage 45.84% 82.27% +36.42%
===========================================
Files 199 81 -118
Lines 7499 1213 -6286
Branches 1714 256 -1458
===========================================
- Hits 3438 998 -2440
+ Misses 3683 186 -3497
+ Partials 378 29 -349 |
TkDodo
reviewed
Nov 15, 2024
TkDodo
approved these changes
Nov 15, 2024
Collaborator
Author
|
I'll fix type error soon |
Collaborator
Author
|
I resolved it now😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.