Skip to content

feat(eslint-plugin-query): enhance no-rest-destructuring rule to detect spread operations #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TkDodo merged 1 commit into from
Mar 14, 2025
Merged

feat(eslint-plugin-query): enhance no-rest-destructuring rule to detect spread operations #8802

TkDodo merged 1 commit into from
Mar 14, 2025

Conversation

@Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Mar 13, 2025

closes #8747

@nx-cloud
Copy link

nx-cloud bot commented Mar 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e1fdc33.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 12s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-13 18:14:51 UTC

@Newbie012 Newbie012 force-pushed the feat-enhance-no-rest-destructuring-rule branch from b8646d3 to cde8a93 Compare March 13, 2025 18:11
@Newbie012 Newbie012 force-pushed the feat-enhance-no-rest-destructuring-rule branch from cde8a93 to e1fdc33 Compare March 13, 2025 18:12
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8802

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8802

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8802

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8802

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8802

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8802

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8802

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8802

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8802

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8802

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8802

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8802

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8802

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8802

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8802

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8802

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8802

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8802

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8802

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8802

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8802

commit: e1fdc33

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Sizes for commit e1fdc33:

Branch Bundle Size
Main
This PR

@codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.81%. Comparing base (d7f4cb0) to head (e1fdc33).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8802       +/-   ##
===========================================
+ Coverage   46.37%   87.81%   +41.44%     
===========================================
  Files         199       15      -184     
  Lines        7551      509     -7042     
  Branches     1732      190     -1542     
===========================================
- Hits         3502      447     -3055     
+ Misses       3669       48     -3621     
+ Partials      380       14      -366
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 87.81% <84.21%> (-0.22%) ⬇️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit 796032d into main Mar 14, 2025
7 checks passed
@TkDodo TkDodo deleted the feat-enhance-no-rest-destructuring-rule branch March 14, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[lint]: no-rest-destructuring only reports on inline destructuring

2 participants

@Newbie012 @TkDodo