fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types
#9030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 7c34847.
☁️ Nx Cloud last updated this comment at |
custardcream98
force-pushed
the
fix/preserve-set-query-data-type-inference
branch
from
a164952 to
7c34847
Compare
custardcream98
changed the title
setQueryData when used in functions with explicit return typessetQueryData when used in functions with explicit return types
Contributor
Author
|
The CI test failure seems unrelated to the changes in this PR. My changes only affect TypeScript type definitions and a type test, with no runtime behavior modifications. The failure appears to be in an unrelated test. |
TkDodo
approved these changes
Apr 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9030 +/- ##
===========================================
+ Coverage 44.58% 59.02% +14.44%
===========================================
Files 203 138 -65
Lines 8106 5360 -2746
Branches 1801 1426 -375
===========================================
- Hits 3614 3164 -450
+ Misses 4060 1907 -2153
+ Partials 432 289 -143 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the
NoInferutility type to the return type ofsetQueryDatato prevent the outer function's return type from affecting the updater function's type inference.closes #9024