Skip to content

Conversation

@prateek3255
Copy link
Contributor

Fixes #4097

@prateek3255 prateek3255 changed the title perf(devtools): Memoize QueryRow perf(devtools): Memoize Devtools QueryRow Oct 31, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a85233d:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@prateek3255
Copy link
Contributor Author

@TkDodo I am not sure why but some random useQuery test is failing here:
image

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 1, 2022

will you add not rendering the devtools at all when they are collapsed in a separate PR ?

@prateek3255
Copy link
Contributor Author

@TkDodo Wasn't that already done as part of #4146 ?

https://github.com/TanStack/query/pull/4146/files#diff-c992b3e7d0c726ede60fddfed04ea2b417fe3f708ba78ab43fe4f82c7d8faa25R511-R512

@TkDodo TkDodo merged commit b65725c into TanStack:main Nov 1, 2022
@prateek3255 prateek3255 deleted the optimize-devtools branch November 6, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devtools are re-rerendering constantly on every cache update even when closed

2 participants