Skip to content

Fix JSON formatting in detailed view. #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Fix JSON formatting in detailed view. #4418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3569db1
Fix JSON formatting in detailed view.
mc-petry Oct 31, 2022
9b34d3f
Merge branch 'main' into fix/json-bigint
TkDodo Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-query-devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
getResizeHandleStyle,
getSidedProp,
defaultPanelSize,
displayValue,
} from './utils'
import type { Corner, Side } from './utils'
import {
Expand Down Expand Up @@ -846,7 +847,7 @@ const ActiveQuery = ({
overflow: 'auto',
}}
>
{JSON.stringify(activeQuery.queryKey, null, 2)}
{displayValue(activeQuery.queryKey, true)}
</pre>
</Code>
<span
Expand Down
5 changes: 3 additions & 2 deletions packages/react-query-devtools/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,12 @@ export function useIsMounted() {
/**
* Displays a string regardless the type of the data
* @param {unknown} value Value to be stringified
* @param {boolean} beautify Formats json to multiline
*/
export const displayValue = (value: unknown) => {
export const displayValue = (value: unknown, beautify: boolean = false) => {
const { json } = SuperJSON.serialize(value)

return JSON.stringify(json)
return JSON.stringify(json, null, beautify ? 2 : undefined)
}

// Sorting functions
Expand Down