Skip to content

fix(eslint-plugin): get identifiers from unary, chain, and ts-non-null expressions #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 4, 2022
Merged

fix(eslint-plugin): get identifiers from unary, chain, and ts-non-null expressions #4448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62b35b7
fix unary expression
Newbie012 Nov 3, 2022
830184a
fix chain expression
Newbie012 Nov 3, 2022
3b7bc1c
fix ts non null expression
Newbie012 Nov 3, 2022
3e16948
format
Newbie012 Nov 3, 2022
33bb0f0
Merge branch 'main' into fix-nested-identifiers
TkDodo Nov 4, 2022
6125df3
Merge branch 'main' into fix-nested-identifiers
TkDodo Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/eslint-plugin-query/src/rules/exhaustive-deps/exhaustive-deps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,31 @@ ruleTester.run('exhaustive-deps', rule, {
}
`,
},
{
name: 'identify !!props.id (unary expression)',
code: `
function MyComponent(props) {
useQuery({ queryKey: ["entity", !!props.id], queryFn: () => api.entity.get(props.id) });
}
`,
},
{
name: 'identify props?.id (chain expression)',
code: `
function MyComponent(props) {
useQuery({ queryKey: ["entity", props?.id], queryFn: () => api.entity.get(props?.id) });
}
`,
},
{
only: true,
name: 'identify props!.id (ts non null expression)',
code: `
function MyComponent(props) {
useQuery({ queryKey: ["entity", props!.id], queryFn: () => api.entity.get(props!.id) });
}
`,
},
{
name: 'should ignore keys from callback',
code: `
Expand Down
12 changes: 12 additions & 0 deletions packages/eslint-plugin-query/src/utils/ast-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,18 @@ export const ASTUtils = {
identifiers.push(...ASTUtils.getNestedIdentifiers(node.object))
}

if (node.type === AST_NODE_TYPES.UnaryExpression) {
identifiers.push(...ASTUtils.getNestedIdentifiers(node.argument))
}

if (node.type === AST_NODE_TYPES.ChainExpression) {
identifiers.push(...ASTUtils.getNestedIdentifiers(node.expression))
}

if (node.type === AST_NODE_TYPES.TSNonNullExpression) {
identifiers.push(...ASTUtils.getNestedIdentifiers(node.expression))
}

return identifiers
},
isAncestorIsCallee(identifier: TSESTree.Node) {
Expand Down