Skip to content

Conversation

@danawoodman
Copy link
Contributor

@danawoodman danawoodman commented Aug 5, 2023

SvelteKit now automatically infers the type of an exported load method, so no need to manually define it.

Also, Github has an ongoing issue with the Svelte syntax highlighting so using html is a good fallback.

View changes here

SvelteKit now automatically infers the type of an exported load method, so no need to manually define it.

Also, Github has an ongoing issue with the Svelte syntax highlighting so using `html` is a good fallback.
@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 0:59am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cfe87d7:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@danawoodman
Copy link
Contributor Author

Hello? 🤔👀

Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danawoodman, thanks for the submission! I'm happy with the auto types for load functions, but I would like to keep the codeblocks as svelte. The docs are primarily meant to be read on tanstack.com, and the change from html to svelte was so we could add proper prism svelte highlighting.

Progress here has been stalled - you can see my PRs here:

I might just go ahead and copy the prism-svelte code into the tanstack.com repo so this can highlight correctly.

@danawoodman
Copy link
Contributor Author

@lachlancollins do you want me to undo the svelte=>html changes?

@danawoodman
Copy link
Contributor Author

@lachlancollins sorry for delay, I've reverted the code block changes

@lachlancollins lachlancollins merged commit 17661f6 into TanStack:main Nov 1, 2023
@danawoodman danawoodman deleted the main-1 branch November 5, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants