-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Simplify load method, fix syntax highlighting #5844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SvelteKit now automatically infers the type of an exported load method, so no need to manually define it. Also, Github has an ongoing issue with the Svelte syntax highlighting so using `html` is a good fallback.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfe87d7:
|
|
Hello? 🤔👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danawoodman, thanks for the submission! I'm happy with the auto types for load functions, but I would like to keep the codeblocks as svelte. The docs are primarily meant to be read on tanstack.com, and the change from html to svelte was so we could add proper prism svelte highlighting.
Progress here has been stalled - you can see my PRs here:
I might just go ahead and copy the prism-svelte code into the tanstack.com repo so this can highlight correctly.
|
@lachlancollins do you want me to undo the svelte=>html changes? |
|
@lachlancollins sorry for delay, I've reverted the code block changes |
SvelteKit now automatically infers the type of an exported load method, so no need to manually define it.
Also, Github has an ongoing issue with the Svelte syntax highlighting so using
htmlis a good fallback.View changes here