fix(devtools): fix restore/trigger loading cond

[judicaelandria]

This PR fix the button trigger loading state
closes #5959

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Sep 18, 2023 4:43pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1403984. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx affected --targets=test:eslint,test:lib,test:types,test:build,test:bundle

---

Sent with 💌 from NxCloud.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1403984:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[TkDodo]

if I now click trigger loading, it doesn't change to restore loading either.

not sure why, maybe that state isn't what we're actually looking for 🤷

@ardeora might be able to help here. Also, we're still missing the tests for the devtools from v4. @ardeora I could start adding them for the react adapter, but I think most tests should actually be for the agnostic query-devtools package, right? So I'd need to see one or two examples to get this going because I've never written a test in solid 😬

[judicaelandria]

hmm that's weird, I'll have a closer look again to see if I can find the real state

[judicaelandria]

@TkDodo I think it should work as expected now

[ardeora]

This is looking good! I can see the expected behavior here. One thing that could also be addressed in this PR maybe that when Trigger loading is clicked. We should disable Trigger Error button? Ideally we should be able to trigger an Error while in loading state, but currently seems way more complex to achieve this

[ardeora]

if I now click trigger loading, it doesn't change to restore loading either.

not sure why, maybe that state isn't what we're actually looking for 🤷

@ardeora might be able to help here. Also, we're still missing the tests for the devtools from v4. @ardeora I could start adding them for the react adapter, but I think most tests should actually be for the agnostic query-devtools package, right? So I'd need to see one or two examples to get this going because I've never written a test in solid 😬

I have been trying to add the tests. The only issue currently I'm stuck on is we use the ResizeObserver API to correctly add breakpoints to split the query details view 50/50 on smaller widths. The ResizeObserver API currently doesn't exist in jsdom so that causes the tests to error. Trying to find a workaround to that.

[judicaelandria]

We should disable Trigger Error button? Ideally we should be able to trigger an Error while in loading state, but currently seems way more complex to achieve this

yes, I'll disable to the button while in loading state

[TkDodo]

looks good, but please also disable the invalidate and reset button, as they will also trigger a refetch. clicking them will make the restore loading not work

[judicaelandria]

@TkDodo fixed