Skip to content

Conversation

@ardeora
Copy link
Contributor

@ardeora ardeora commented Oct 14, 2023

Fixes #6153

This change makes all the internal fields of the core query devtools private to prevent users from accidentally mutating internal values. We have implemented getters and setters to allow controlled access to select private fields. Should there be a need to expose additional fields from the core devtools in the future, we can address that as necessary.

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:02pm

@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8cb1e8a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8cb1e8a:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/query-devtools/src/utils.tsx 49.20% <74.64%> (ø)

... and 80 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ardeora ardeora merged commit 9ed5a76 into TanStack:rc Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants