fix(core): mutation GC leak when reset, but not unsubscribed #6509
Conversation
mutations were not gc'd correctly when being reset. GC was invoked on unsubscribe, but reset disconnects the observer from the mutation in the cache and must thus also trigger a GC, because the observer is no longer watching the values of that mutation, and another mutate() call will create a new mutation anyway. Thus, the old mutation becomes orphaned when reset is called.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 81038ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 81038ac:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6509 +/- ##
==========================================
+ Coverage 87.83% 88.39% +0.56%
==========================================
Files 87 75 -12
Lines 2926 2585 -341
Branches 803 680 -123
==========================================
- Hits 2570 2285 -285
+ Misses 297 255 -42
+ Partials 59 45 -14 ☔ View full report in Codecov by Sentry. |
mutations were not gc'd correctly when being reset. GC was invoked on unsubscribe, but reset disconnects the observer from the mutation in the cache and must thus also trigger a GC, because the observer is no longer watching the values of that mutation, and another mutate() call will create a new mutation anyway. Thus, the old mutation becomes orphaned when reset is called.