Skip to content

Conversation

@arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Dec 23, 2023

Fixes #6567

observer.getOptimisticResult was not called correctly when changing query options.

Also removes property tracking optimization as it's not needed for Angular.

@vercel
Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2023 3:52pm

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 40bd67a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 40bd67a:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1340d59) 87.93% compared to head (40bd67a) 90.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
+ Coverage   87.93%   90.10%   +2.17%     
==========================================
  Files          87        8      -79     
  Lines        2934       91    -2843     
  Branches      807        4     -803     
==========================================
- Hits         2580       82    -2498     
+ Misses        295        9     -286     
+ Partials       59        0      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnoud-dv arnoud-dv force-pushed the fix/angular-query-optimistic-result branch from 0f5784d to bebd090 Compare December 23, 2023 15:48
@arnoud-dv arnoud-dv force-pushed the fix/angular-query-optimistic-result branch from bebd090 to 40bd67a Compare December 23, 2023 15:52
@arnoud-dv arnoud-dv marked this pull request as ready for review December 23, 2023 16:01
@arnoud-dv arnoud-dv merged commit fdcdfdc into TanStack:main Dec 23, 2023
@arnoud-dv arnoud-dv deleted the fix/angular-query-optimistic-result branch December 23, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular Query's data signal is not updating if data is present in the cache

2 participants