Skip to content

Conversation

@arnoud-dv
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 31, 2023 1:09pm

@nx-cloud
Copy link

nx-cloud bot commented Dec 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7caab75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7caab75:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@arnoud-dv arnoud-dv force-pushed the feature/angular-mutation-state branch from 1af5f29 to 7caab75 Compare December 31, 2023 13:09
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3265ec3) 39.37% compared to head (7caab75) 82.92%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ar-query-experimental/src/inject-mutation-state.ts 95.45% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6621       +/-   ##
===========================================
+ Coverage   39.37%   82.92%   +43.54%     
===========================================
  Files         163       14      -149     
  Lines        6633      164     -6469     
  Branches     1319       26     -1293     
===========================================
- Hits         2612      136     -2476     
+ Misses       3670       28     -3642     
+ Partials      351        0      -351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +51 to +58
() => {
// Setting the signal from an effect because it's both 'computed' from options()
// and needs to be set imperatively in the mutationCache listener.
result.set(getResult(mutationCache, options()))
},
{
allowSignalWrites: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
() => {
// Setting the signal from an effect because it's both 'computed' from options()
// and needs to be set imperatively in the mutationCache listener.
result.set(getResult(mutationCache, options()))
},
{
allowSignalWrites: true,
},
() => {
const options = options();
// Setting the signal from an effect because it's both 'computed' from options()
// and needs to be set imperatively in the mutationCache listener.
untracked(() => result.set(getResult(mutationCache, options)));
},

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the suggested change for this reason? https://twitter.com/GergelySzerovay/status/1754915190213144949

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. More here: angular/angular#53986

@arnoud-dv arnoud-dv closed this Feb 17, 2024
@adam4nj
Copy link

adam4nj commented Feb 18, 2024

is injectMutationState not going to be implemented?

@arnoud-dv
Copy link
Collaborator Author

arnoud-dv commented Feb 18, 2024

is injectMutationState not going to be implemented?

Probably today, but this PR was very old and it's easier to open a new PR instead of resolving all the conflicts.

New PR: #6925

@arnoud-dv
Copy link
Collaborator Author

@adam4nj injectMutationState is now available in v5.22 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants