-
-
Couldn't load subscription status.
- Fork 3.5k
feat(angular-query): add injectMutationState #6621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7caab75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7caab75:
|
1af5f29 to
7caab75
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6621 +/- ##
===========================================
+ Coverage 39.37% 82.92% +43.54%
===========================================
Files 163 14 -149
Lines 6633 164 -6469
Branches 1319 26 -1293
===========================================
- Hits 2612 136 -2476
+ Misses 3670 28 -3642
+ Partials 351 0 -351 ☔ View full report in Codecov by Sentry. |
| () => { | ||
| // Setting the signal from an effect because it's both 'computed' from options() | ||
| // and needs to be set imperatively in the mutationCache listener. | ||
| result.set(getResult(mutationCache, options())) | ||
| }, | ||
| { | ||
| allowSignalWrites: true, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| () => { | |
| // Setting the signal from an effect because it's both 'computed' from options() | |
| // and needs to be set imperatively in the mutationCache listener. | |
| result.set(getResult(mutationCache, options())) | |
| }, | |
| { | |
| allowSignalWrites: true, | |
| }, | |
| () => { | |
| const options = options(); | |
| // Setting the signal from an effect because it's both 'computed' from options() | |
| // and needs to be set imperatively in the mutationCache listener. | |
| untracked(() => result.set(getResult(mutationCache, options))); | |
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the suggested change for this reason? https://twitter.com/GergelySzerovay/status/1754915190213144949
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. More here: angular/angular#53986
|
is injectMutationState not going to be implemented? |
Probably today, but this PR was very old and it's easier to open a new PR instead of resolving all the conflicts. New PR: #6925 |
No description provided.