Skip to content

ci: Avoid uploading coverage files in Nx cache #6644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

ci: Avoid uploading coverage files in Nx cache #6644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333ee1b
ci: Avoid uploading coverage files in Nx cache
lachlancollins Jan 5, 2024
6cda375
Clean up config
lachlancollins Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
if: github.repository == 'TanStack/query'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: '0'
- name: Setup pnpm
Expand All @@ -36,7 +37,7 @@ jobs:
node-version-file: .nvmrc
cache: pnpm
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
run: pnpm install --frozen-lockfile --prefer-offline
- name: Run Tests
run: pnpm run test:ci
- name: Publish
Expand All @@ -53,3 +54,5 @@ jobs:
TAG: ${{ inputs.tag }}
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
directory: packages
22 changes: 9 additions & 13 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
name: Nx Cloud - Main Job
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup pnpm
Expand All @@ -35,16 +36,12 @@ jobs:
with:
node-version-file: .nvmrc
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
- name: Get appropriate base and head commits for `nx affected` commands
run: pnpm install --frozen-lockfile --prefer-offline
- name: Get base and head commits for `nx affected`
uses: nrwl/nx-set-shas@v3
with:
main-branch-name: 'main'
- run: |
echo "BASE: ${{ env.NX_BASE }}"
echo "HEAD: ${{ env.NX_HEAD }}"
- name: Start CI Orchestrator
run: npx nx-cloud start-ci-run
- name: Run Tests
Expand All @@ -54,6 +51,8 @@ jobs:
run: npx nx-cloud stop-all-agents
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
directory: packages
agents:
name: Nx Cloud - Agents
runs-on: ubuntu-latest
Expand All @@ -74,9 +73,8 @@ jobs:
with:
node-version-file: .nvmrc
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
run: pnpm install --frozen-lockfile --prefer-offline
- name: Start Nx Agent ${{ matrix.agent }}
run: npx nx-cloud start-agent
format:
Expand All @@ -95,9 +93,8 @@ jobs:
with:
node-version-file: .nvmrc
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
run: pnpm install --frozen-lockfile --prefer-offline
- name: Run prettier
run: pnpm run test:format
knip:
Expand All @@ -116,8 +113,7 @@ jobs:
with:
node-version-file: .nvmrc
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
- name: Install dependencies
run: pnpm --filter "./packages/**" --filter query --prefer-offline install
run: pnpm install --frozen-lockfile --prefer-offline
- name: Run Knip
run: pnpm knip