Skip to content

Conversation

@lachlancollins
Copy link
Member

  • Removed noImplicitAny and noImplicitThis (enabled by strict)
  • Removed declarationMap (tsup does not build declaration maps regardless of this option)
  • Removed baseUrl (was used in v4 when paths/references were used for resolution)
    • Fixed This is likely not portable. A type annotation is necessary. issue in useBaseQuery.ts

@vercel
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 11:33pm

@nx-cloud
Copy link

nx-cloud bot commented Jan 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9b27f66. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b27f66:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f43d2ad) 41.74% compared to head (9b27f66) 41.71%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6653      +/-   ##
==========================================
- Coverage   41.74%   41.71%   -0.04%     
==========================================
  Files         179      179              
  Lines        7011     7007       -4     
  Branches     1419     1416       -3     
==========================================
- Hits         2927     2923       -4     
  Misses       3713     3713              
  Partials      371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins changed the title chore: Remove unnecessary tsconfig options fix: Remove unnecessary tsconfig options Jan 5, 2024
@lachlancollins lachlancollins merged commit e5f23fc into TanStack:main Jan 5, 2024
@lachlancollins lachlancollins deleted the tsconfig branch January 5, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants