fix(angular-query): support required input signal

[arnoud-dv]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Feb 19, 2024 1:21am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bcf4af9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

---

Sent with 💌 from NxCloud.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bcf4af9:

Sandbox	Source
@tanstack/query-example-angular-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[codecov-commenter]

Codecov Report

Merging #6928 (bcf4af9) into main (75b9c57) will increase coverage by 0.08%.
The diff coverage is 92.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6928      +/-   ##
==========================================
+ Coverage   41.98%   42.06%   +0.08%     
==========================================
  Files         179      180       +1     
  Lines        7039     7060      +21     
  Branches     1421     1422       +1     
==========================================
+ Hits         2955     2970      +15     
- Misses       3722     3727       +5     
- Partials      362      363       +1     

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	∅ <ø> (∅)
@tanstack/angular-query-experimental	82.29% <92.10%> (-1.34%)	⬇️
@tanstack/eslint-plugin-query	85.11% <ø> (ø)
@tanstack/query-async-storage-persister	48.43% <ø> (ø)
@tanstack/query-broadcast-client-experimental	∅ <ø> (∅)
@tanstack/query-codemods	0.00% <ø> (ø)
@tanstack/query-core	93.63% <ø> (ø)
@tanstack/query-devtools	4.46% <ø> (ø)
@tanstack/query-persist-client-core	57.73% <ø> (ø)
@tanstack/query-sync-storage-persister	82.50% <ø> (ø)
@tanstack/react-query	93.07% <ø> (ø)
@tanstack/react-query-devtools	0.00% <ø> (ø)
@tanstack/react-query-next-experimental	∅ <ø> (∅)
@tanstack/react-query-persist-client	100.00% <ø> (ø)
@tanstack/solid-query	84.84% <ø> (ø)
@tanstack/solid-query-devtools	∅ <ø> (∅)
@tanstack/solid-query-persist-client	100.00% <ø> (ø)
@tanstack/svelte-query	62.68% <ø> (ø)
@tanstack/svelte-query-devtools	∅ <ø> (∅)
@tanstack/svelte-query-persist-client	100.00% <ø> (ø)
@tanstack/vue-query	70.81% <ø> (ø)
@tanstack/vue-query-devtools	∅ <ø> (∅)

[riccardoperra]

@arnoud-dv Not able to fill a documented issue right now but we are experiencing a NG0602 with the latest angular-query update

The error seems occur in all pages were we aren't using required signal inputs, this may be related to some timing issues.

Currently we are downgrading the version, but as a workaround in that pages we were "initializing" the object in the constructor

  readonly query = injectQuery(() => ({
    queryKey: [...],
    queryFn: () => {
      return lastValueFrom(...);
    },
    staleTime: Infinity,
    retry: 2,
  }));

 constructor() {
   void this.query.anyProperty;
 }

[arnoud-dv]

The error seems occur in all pages were we aren't using required signal inputs, this may be related to some timing issues.

@riccardoperra Thank you for reporting this.

Examples without required signal inputs are working for me. Do you have some more code for me to try to reproduce this? I think I can look at it this evening.

[riccardoperra]

Did a small repro 😄

https://stackblitz.com/edit/stackblitz-starters-4favya?file=src%2Fmain.ts

It doesn't seem to be blocking, it seems to work but I wouldn't want that error to block effects used internally