Skip to content

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Jun 1, 2024

Because of #7499 (comment)

I knew you(@TkDodo) don't use VSCode but as you know really many people use VSCode. If someone contributes with a simple modification to the official document, they can make a Pull Request without having to format the prettier with the help of husky, since they do it without even installing pnpm. I hope this change will lower maintenance costs by preventing cases like this early on.

@vercel
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 1:07pm

@manudeli manudeli marked this pull request as ready for review June 1, 2024 20:49
@nx-cloud
Copy link

nx-cloud bot commented Jun 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27af79d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@manudeli manudeli changed the title chore(.vscode): force format on save by prettier chore(.vscode): force format on save by prettier without husky install Jun 1, 2024
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27af79d:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 7, 2024

I think having the precommit hook and the CI checks should be enough. I don't think we should check in editor specific settings, as it might lead to people accidentally committing their personal settings and then PRs will be even slower because we need to remind them to not do that.

@TkDodo TkDodo closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants