Skip to content

ci(pnpm): Add .pnpmfile.cjs to remove indirect dependencies #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 11, 2024
Merged

ci(pnpm): Add .pnpmfile.cjs to remove indirect dependencies #7667

merged 8 commits into from
Jul 11, 2024

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jul 3, 2024 •
edited
Loading

  • This removes heaps of indirect dependencies added by react-scripts v4 and v5
  • This has no impact on the integration build tests (only removes eslint/jest packages)
  • 3728 -> 3462 dependencies
  • Feature documentation here: https://pnpm.io/pnpmfile#usage

@lachlancollins lachlancollins changed the title ci(pnpm): Add .pnpmfile.cjs to remove unused dependencies ci(pnpm): Add .pnpmfile.cjs to remove indirect dependencies Jul 3, 2024
@nx-cloud
Copy link

nx-cloud bot commented Jul 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f6afc9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.56%. Comparing base (b58da75) to head (8f6afc9).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7667   +/-   ##
=======================================
  Coverage   44.56%   44.56%           
=======================================
  Files         185      185           
  Lines        7062     7062           
  Branches     1555     1553    -2     
=======================================
  Hits         3147     3147           
  Misses       3552     3552           
  Partials      363      363
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query 84.36% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 92.86% <ø> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.98% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 90.00% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.42% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins marked this pull request as ready for review July 4, 2024 00:06
@lachlancollins lachlancollins requested a review from TkDodo July 4, 2024 00:07
@TanStack TanStack deleted a comment from vercel bot Jul 6, 2024
@TanStack TanStack deleted a comment from codesandbox-ci bot Jul 6, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 6, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 8f6afc9

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7667

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7667

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7667

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7667

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7667

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7667

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7667

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7667

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7667

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7667

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7667

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7667

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7667

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7667

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7667

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7667

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7667

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7667

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7667

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7667

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7667

templates

@lachlancollins lachlancollins merged commit 5c9efe8 into main Jul 11, 2024
@lachlancollins lachlancollins deleted the pnpmfile branch July 11, 2024 05:26
@lachlancollins lachlancollins mentioned this pull request Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo Awaiting requested review from TkDodo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lachlancollins