ci: prepare for trusted publishing #9952

lachlancollins · 2025-12-06T14:37:48Z

🎯 Changes

Sync changes from other projects
Remove NPM_TOKEN

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated CI workflow tools and GitHub Actions to latest stable versions
- Updated core dependencies for improved build performance
- Enhanced GitHub issue template with new community contact options
- Standardized repository URL format across package manifests

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-12-06T14:37:52Z

⚠️ No Changeset found

Latest commit: c9e5aad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-06T14:37:59Z

Caution

Review failed

The pull request is closed.

Walkthrough

This PR consolidates configuration and type system updates across the TanStack Query monorepo: standardizing repository URLs from HTTPS to git+https format in all package.json files, updating CI workflows (actions/checkout v6.0.1, nx-set-shas v4.4.0), refactoring interface signatures to remove OmitKeyof wrappers, bumping dependencies, and updating module compilation target.

Changes

Cohort / File(s)	Summary
GitHub Templates & Workflows `.github/ISSUE_TEMPLATE/config.yml`, `.github/workflows/autofix.yml`, `.github/workflows/pr.yml`, `.github/workflows/release.yml`	Updated GitHub issue template contact links with emoji and TanStack branding; bumped actions/checkout from v5.0.0 to v6.0.1 across three workflows; upgraded nx-set-shas from v4.3.3 to v4.4.0; renamed formatter step; removed NPM_TOKEN from release workflow.
Root Configuration `package.json`, `tsconfig.json`	Updated repository URL format; removed test:format script; reorganized prettier/format scripts; updated dependencies (`@tanstack/vite-config`, nx, prettier); removed pnpm overrides block; changed tsconfig module from ES2022 to ESNext.
Package Repository URLs `packages/*/package.json` (28 files)	Standardized repository URL across all packages from `https://github.com/TanStack/query.git` to `git+https://github.com/TanStack/query.git`.
Core Type Definitions `packages/query-core/src/types.ts`	Refactored public interface signatures: replaced `WithRequired` pattern with direct extends; reformatted `QueryObserverOptions`, `InfiniteQueryObserverOptions`, `FetchQueryOptions`, `EnsureQueryDataOptions`, `InvalidateQueryFilters`, `RefetchQueryFilters`, and mutation-related result types; added explicit generic parameter declarations.
React Query Type Definitions `packages/react-query/src/types.ts`	Replaced `OmitKeyof` wrappers with direct extends patterns across `UsePrefetchQueryOptions`, `UseQueryOptions`, `UseSuspenseQueryOptions`, `UseInfiniteQueryOptions`, `UseSuspenseInfiniteQueryOptions`, and `UseMutationOptions`.
Angular Query Types & Persist `packages/angular-query-experimental/src/types.ts`, `packages/query-persist-client-core/src/persist.ts`	Refactored `CreateMutationOptions` to extend `MutationObserverOptions` instead of omitting `_defaulted`; applied formatting adjustments to persist interface declarations.
Solid Query Types & Client `packages/solid-query/src/QueryClient.ts`, `packages/solid-query/src/types.ts`	Replaced `OmitKeyof` with direct extends for `QueryObserverOptions`, `InfiniteQueryObserverOptions`, and `DefaultOptions`; refactored `UseBaseQueryOptions`, `SolidQueryOptions`, `SolidInfiniteQueryOptions`, and `SolidMutationOptions` signatures.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Type signature changes across multiple packages: Verify that replacing OmitKeyof with direct extends patterns preserves type semantics and doesn't break downstream consumers (query-core, react-query, angular-query, solid-query types.ts files).
Package.json repository URL standardization: Confirm git+https format is compatible with all package managers and CI/CD tooling in use; verify 28 updates are consistent.
Dependency version bumps: Review @tanstack/vite-config (0.4.1→0.4.3), nx (21.5.3→22.1.3), prettier (^3.6.2→^3.7.4) for potential breaking changes or compatibility issues.
CI workflow changes: Ensure actions/checkout v6.0.1 and nx-set-shas v4.4.0 are compatible with existing jobs and don't alter test/preview/provenance behavior.
Removal of pnpm overrides: Verify that removing the workspace override block doesn't cause dependency resolution issues in the monorepo.

Possibly related PRs

ci: sync config between projects #9931: Modifies root package.json scripts and nx.json configuration for CI/docs/test tooling synchronization—related workspace and dependency orchestration changes.
ci: remove @tanstack/publish-config #9930: Updates @tanstack/vite-config dependency and package build configuration—overlaps on dependency bump and config package references.
ci: update workspace config #9671: Modifies repository/workspace metadata and CI/package configuration—similar metadata and CI workflow updates.

Suggested labels

package: eslint-plugin-query

Suggested reviewers

TkDodo
arnoud-dv

Poem

🐰 A rabbit hops through types so neat,
OmitKeyof patterns now obsolete,
Repository links glow git+https bright,
Workflows upgraded, dependencies right,
Configuration squared—a monorepo delight! 🌟

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch trusted-publishing

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ad78fc and c9e5aad.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (33)

.github/ISSUE_TEMPLATE/config.yml (1 hunks)
.github/workflows/autofix.yml (1 hunks)
.github/workflows/pr.yml (3 hunks)
.github/workflows/release.yml (1 hunks)
package.json (4 hunks)
packages/angular-query-experimental/src/types.ts (3 hunks)
packages/angular-query-persist-client/package.json (1 hunks)
packages/query-async-storage-persister/package.json (1 hunks)
packages/query-broadcast-client-experimental/package.json (1 hunks)
packages/query-codemods/package.json (1 hunks)
packages/query-core/package.json (1 hunks)
packages/query-core/src/types.ts (9 hunks)
packages/query-devtools/package.json (1 hunks)
packages/query-persist-client-core/package.json (1 hunks)
packages/query-persist-client-core/src/persist.ts (2 hunks)
packages/query-sync-storage-persister/package.json (1 hunks)
packages/query-test-utils/package.json (1 hunks)
packages/react-query-devtools/package.json (1 hunks)
packages/react-query-next-experimental/package.json (1 hunks)
packages/react-query-persist-client/package.json (1 hunks)
packages/react-query/package.json (1 hunks)
packages/react-query/src/types.ts (7 hunks)
packages/solid-query-devtools/package.json (1 hunks)
packages/solid-query-persist-client/package.json (1 hunks)
packages/solid-query/package.json (1 hunks)
packages/solid-query/src/QueryClient.ts (3 hunks)
packages/solid-query/src/types.ts (4 hunks)
packages/svelte-query-devtools/package.json (1 hunks)
packages/svelte-query-persist-client/package.json (1 hunks)
packages/svelte-query/package.json (1 hunks)
packages/vue-query-devtools/package.json (1 hunks)
packages/vue-query/package.json (1 hunks)
tsconfig.json (1 hunks)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-12-06T14:38:20Z

View your CI Pipeline Execution ↗ for commit c9e5aad

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	46s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-06 14:46:53 UTC

pkg-pr-new · 2025-12-06T14:42:05Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9952

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9952

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9952

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9952

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9952

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9952

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9952

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9952

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9952

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9952

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9952

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9952

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9952

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9952

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9952

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9952

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9952

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9952

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9952

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9952

commit: c9e5aad

github-actions · 2025-12-06T14:42:06Z

Sizes for commit c9e5aad:

Branch	Bundle Size
Main
This PR

codecov · 2025-12-06T14:47:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.89%. Comparing base (5ad78fc) to head (c9e5aad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9952   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files         200      200           
  Lines        8437     8437           
  Branches     1940     1933    -7     
=======================================
  Hits         3872     3872           
  Misses       4116     4116           
  Partials      449      449

Components	Coverage Δ
@tanstack/angular-query-experimental	`93.85% <ø> (ø)`
@tanstack/eslint-plugin-query	`83.59% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`97.39% <ø> (ø)`
@tanstack/query-devtools	`3.48% <ø> (ø)`
@tanstack/query-persist-client-core	`80.00% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`77.77% <ø> (ø)`
@tanstack/react-query	`96.01% <ø> (ø)`
@tanstack/react-query-devtools	`9.25% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`77.81% <ø> (ø)`
@tanstack/solid-query-devtools	`64.17% <ø> (ø)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`71.91% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lachlancollins added 2 commits December 7, 2025 01:37

ci: prepare for trusted publishing

873cbe3

Format

5ad97f2

github-actions bot added package: angular-query-persist-client package: query-test-utils labels Dec 6, 2025

Remove NPM_TOKEN

c9e5aad

lachlancollins merged commit f15b7fc into main Dec 6, 2025
10 of 11 checks passed

lachlancollins deleted the trusted-publishing branch December 6, 2025 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci: prepare for trusted publishing #9952

ci: prepare for trusted publishing #9952

lachlancollins commented Dec 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Dec 6, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 6, 2025 •

edited

Loading

Review failed

Uh oh!

nx-cloud bot commented Dec 6, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Dec 6, 2025

Uh oh!

github-actions bot commented Dec 6, 2025

Uh oh!

codecov bot commented Dec 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

ci: prepare for trusted publishing #9952

ci: prepare for trusted publishing #9952

Conversation

lachlancollins commented Dec 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

nx-cloud bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 6, 2025

Uh oh!

github-actions bot commented Dec 6, 2025

Uh oh!

codecov bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lachlancollins commented Dec 6, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Dec 6, 2025 •

edited

Loading

coderabbitai bot commented Dec 6, 2025 •

edited

Loading

nx-cloud bot commented Dec 6, 2025 •

edited

Loading

codecov bot commented Dec 6, 2025 •

edited

Loading