Laravel 12 Compatibility ... continued #29
Merged
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hold on. Didn't see the failures on my branch. I'll fix it. |
flexgrip
force-pushed
the
patch-1
branch
3 times, most recently
from
b8cc488 to
b830da3
Compare
Contributor
Author
|
Ok sorry. All tests pass now for all veriations of Laravel 9-12 and php 8.0-8.3. Side note, looks like psalm can be removed. It isn't being used. At least by the automation. Maybe you had that in there because you run it manually? |
swilla
approved these changes
Nov 25, 2025
Member
swilla
left a comment
swilla
left a comment
There was a problem hiding this comment.
Thank you! I don't remember why psalm is in there, but we can leave it there unless it's causing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR is a continuation of #28 from @azimidev
You requested in #28 (review) that he add 12 to the matrix. But you didn't have anything after L9 in the testing matrix.
I added all of them up to L12. Hopefully this works and you can quickly approve this because I intend to use it.
P.S. Sorry @azimidev. You didn't check the box to allow edits so I had to open a new PR.
Thanks!