Feature/infra 2354 updated makefile #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…office + fixed some warnings that the new make update stated - removed deprecated ioutils - fixed formatting main.go - improved performance with regex
Contributor
Author
|
TheM1984
dismissed
Lveltmaat’s stale review
The merge-base changed after approval.
Lveltmaat
previously approved these changes
Jan 9, 2024
rtuk
previously approved these changes
Jan 9, 2024
rtuk
previously approved these changes
Jan 9, 2024
Lveltmaat
approved these changes
Jan 9, 2024
Lveltmaat
previously approved these changes
Jan 9, 2024
TheM1984
dismissed
Lveltmaat’s stale review
The merge-base changed after approval.
Lveltmaat
previously approved these changes
Jan 9, 2024
TheM1984
dismissed
Lveltmaat’s stale review
The merge-base changed after approval.
Lveltmaat
previously approved these changes
Jan 9, 2024
TheM1984
dismissed
Lveltmaat’s stale review
The merge-base changed after approval.
…_exporter into feature/INFRA-2354-updated-makefile
Lveltmaat
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a separate PR for this, I tested the changes quickly and everything looks like working accordingly, but wanted to have a 1.8.0 with just dependency updates as well.
With this makefile it should be possible to add a workflow where
make updateis called, all changes are committed, and a PR is created from that.Which would make the update flow somewhat easier.
However that might require some extra unit tests to be added.