Skip to content

Increase test coverage #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2018
Merged

Increase test coverage #5

merged 3 commits into from
Feb 1, 2018

Conversation

@james-od
Copy link
Member

@james-od james-od commented Jan 31, 2018 •
edited
Loading

Issue: #6
Coveralls says we're missing coverage on the post request - the functionality is tested though .

@james-od james-od requested a review from ltorroba January 31, 2018 15:52
@james-od james-od added the Tests label Jan 31, 2018
@coveralls
Copy link

coveralls commented Jan 31, 2018

Pull Request Test Coverage Report for Build 49

  • 26 of 27 (96.3%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+11.0%) to 82.418%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flaskapp/tests.py 26 27 96.3%
Totals Coverage Status
Change from base Build 45: 11.0%
Covered Lines: 75
Relevant Lines: 91
💛 - Coveralls

@james-od james-od merged commit b8fb167 into master Feb 1, 2018
@james-od james-od deleted the increase_test_coverage branch February 1, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ltorroba ltorroba ltorroba approved these changes

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@james-od @coveralls @ltorroba