Making enhanced, interpolated Nanjing lambdas the default #1379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make enhanced, interpolated Nanjing lambdas the default when these are used.
The PR also adds a long-promised Matlab post-processing script for comparing runs. (In order to ease run comparison, several outputs are added to the switch log by default.)
This PR fixes the documentation bug in #1377 .
Attached are some of the outputs of the run comparison script between two runs:
The differences are sufficiently small (for these solar metallicity runs) that this change appears to be safe. Note the more detailed investigation in, e.g., #1343 (reply in thread) .
DCOs: #Merging DNS #Merging NSBH #Merging BBH % BNS via CE % NSBH via CE % BBH via CE
Default: 3 22 29 100 95 86
Enhanced: 3 22 26 100 95 85
LMXBs: #LMXB #NS LMXB
Default: 19 10
Enhanced: 19 10
Supernova statistics: Default Enhanced Interpolated \lambda
Total number of binaries simulated: 10000 10000
Total number of supernovae: 5852 5904
Of these, complete collapse to BH: 809 825
Number of binaries with two SNe: 1854 1867
Number of binaries with one SN: 2144 2170
Number of binaries unbound by SN: 3100 3115
Unbound by first SN: 2712 2726
Unbound by second SN: 388 389
Total number of USSN: 180 186
Total number of ECSN: 176 176
Total number of AIC: 0 0
Total number of PISN: 0 0
Total number of PPISN: 0 0
#SNe from mass-transfering progenitors: 1497 1538
#Stripped-envelope SNe: 2054 2098
Of these, not AIC or ECSN: 1880 1924
Of these, stripped by winds, no RLOF: 562 565
Of these, # stripped by RLOF: 1318 1359
Of these, previous CE: 242 269
Or double-core CE simultaneous with SN: 52 60