Skip to content

Conversation

ilyamandel
Copy link
Collaborator

The goal of this PR is to make enhanced, interpolated Nanjing lambdas the default when these are used.

The PR also adds a long-promised Matlab post-processing script for comparing runs. (In order to ease run comparison, several outputs are added to the switch log by default.)

This PR fixes the documentation bug in #1377 .

Attached are some of the outputs of the run comparison script between two runs:

./COMPAS -n 10000 --switch-log
vs.
./COMPAS -n 10000 --switch-log --common-envelope-lambda-nanjing-enhanced --common-envelope-lambda-nanjing-interpolate-in-mass --common-envelope-lambda-nanjing-interpolate-in-metallicity

The differences are sufficiently small (for these solar metallicity runs) that this change appears to be safe. Note the more detailed investigation in, e.g., #1343 (reply in thread) .

image

image

DCOs: #Merging DNS #Merging NSBH #Merging BBH % BNS via CE % NSBH via CE % BBH via CE
Default: 3 22 29 100 95 86
Enhanced: 3 22 26 100 95 85

LMXBs: #LMXB #NS LMXB
Default: 19 10
Enhanced: 19 10

Supernova statistics: Default Enhanced Interpolated \lambda

Total number of binaries simulated: 10000 10000
Total number of supernovae: 5852 5904
Of these, complete collapse to BH: 809 825
Number of binaries with two SNe: 1854 1867
Number of binaries with one SN: 2144 2170
Number of binaries unbound by SN: 3100 3115
Unbound by first SN: 2712 2726
Unbound by second SN: 388 389

Total number of USSN: 180 186
Total number of ECSN: 176 176
Total number of AIC: 0 0
Total number of PISN: 0 0
Total number of PPISN: 0 0

#SNe from mass-transfering progenitors: 1497 1538
#Stripped-envelope SNe: 2054 2098
Of these, not AIC or ECSN: 1880 1924
Of these, stripped by winds, no RLOF: 562 565
Of these, # stripped by RLOF: 1318 1359
Of these, previous CE: 242 269
Or double-core CE simultaneous with SN: 52 60

@ilyamandel ilyamandel marked this pull request as draft May 1, 2025 10:12
@ilyamandel ilyamandel marked this pull request as ready for review May 1, 2025 10:23
@ilyamandel ilyamandel changed the title Making enhanced, interpolated lambdas the default Making enhanced, interpolated Nanjing lambdas the default May 1, 2025
Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilyamandel . Just a quick review:

(a) in changelog.h you have "Added several outputs to the Switch log..."

"the Switch log" -> BSE switch log

which leads me to,

(b) why not add stellar type, mass, and radius to the SSE switch log? (and if you do, you'll need to make the appropriate changes to the documentation)

EDIT: And as long as you are changing program-options-list-defaults.rst can you fix "multicative" in the description of --timestep-multipliers?

@ilyamandel
Copy link
Collaborator Author

@jeffriley : I hadn't added it to the SSE Switch log because I didn't need it for my particular test, but I agree it's a good idea. So added.

Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilyamandel !

@jeffriley jeffriley merged commit 62110b9 into dev May 1, 2025
3 checks passed
@jeffriley jeffriley deleted the Matlab branch May 1, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants