Skip to content

[Python] Falcon unification issues #8137

@cirospaciari

Description

@cirospaciari

@remittor Thanks for unifying the Falcon code, I really appreciate that and it's the right move for sure. Just opened this issue so we can chat about it.

#8111

This PR has some issues:
Falcon does not need to add Server and Date when using socketify and it adds unnecessary overhead, checking global scope is slow on CPython (but acceptable on PyPy).
The servers should emit these headers or a simple wrapper only on apps that need that to emit this would be a better solution, and fairer with servers that already include this natively.

Performance diffs for socketify WSGI on CPython:
Before: 433,316
After: 356,027

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions