-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Description
@remittor Thanks for unifying the Falcon code, I really appreciate that and it's the right move for sure. Just opened this issue so we can chat about it.
This PR has some issues:
Falcon does not need to add Server and Date when using socketify and it adds unnecessary overhead, checking global scope is slow on CPython (but acceptable on PyPy).
The servers should emit these headers or a simple wrapper only on apps that need that to emit this would be a better solution, and fairer with servers that already include this natively.
Performance diffs for socketify WSGI on CPython:
Before: 433,316
After: 356,027
Metadata
Metadata
Assignees
Labels
No labels