Revert to using Ubuntu 18.04 for the wrk image #7832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nbrady-techempower, similarly to #7783, as far as I can tell, all test failures are caused by implementations that failed during the last continuous run and hence are unrelated, so it seems that my changes are fine. |
Member
|
@volyrique Really appreciate the due diligence. Thanks for taking a look! |
volyrique
added a commit
to volyrique/FrameworkBenchmarks
that referenced
this pull request
Jan 11, 2023
)" This reverts commit b14756a.
volyrique
added a commit
to volyrique/FrameworkBenchmarks
that referenced
this pull request
Jan 13, 2023
)" This reverts commit b14756a.
volyrique
added a commit
to volyrique/FrameworkBenchmarks
that referenced
this pull request
Jan 21, 2023
)" This reverts commit b14756a.
franz1981
pushed a commit
to franz1981/FrameworkBenchmarks
that referenced
this pull request
Jun 23, 2023
…er#7877) * Update MongoDB to version 6.0 and PostgreSQL to version 15 * Revert "Revert wrk to version 4.1.0 (TechEmpower#7852)" This reverts commit 2e2afb8. * Revert "Revert to using Ubuntu 18.04 for the wrk image (TechEmpower#7832)" This reverts commit b14756a. * Clean up several toolset Dockerfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a significant performance regression after #7783 (e.g. check the composite scores), and this PR is an attempt to figure out where the issue is.
In addition to the
wrkversion update, PR #7783 made the following the changes:wrk- I checked the raw data for theh2oimplementation (which covers all defined tests and has been affected negatively) and there were no differences in the valueswrk- the new ones do not have any effect in the continuous benchmarking environment (unlike on other platforms)Concerning the last point, it is possible that the system libraries (e.g. the memory allocator) have received additional security hardening compared to 18.04, which causes the slowdown, so this PR tries to check this theory. Since 18.04 will stop being supported in less than half a year and given that this project is meant to represent a realistic production environment, I expect that we will return to 22.04 eventually, but in the meantime it does not hurt to be aware of any costs.