Fix Next.js 14.1.0 compatibility by improving UMD pattern in opencv.js #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compatibility issue with Next.js 14.1.0 where opencv.js would throw a
TypeError: Cannot set properties of undefined (setting 'cv')
error during module loading.Problem
The error occurred when Next.js 14.1.0 created an environment where:
module.exports
could benull
orundefined
in certain contextsthis
context passed to the UMD wrapper wasundefined
typeof module === 'object' && module.exports
would fail whenmodule.exports
was falsyroot.cv = factory()
whereroot
wasundefined
Solution
Improved CommonJS Detection:
Added Safe Root Fallback:
Better UMD Invocation:
Testing
Usage
Users can now successfully use opencv.js in Next.js 14.1.0 projects without needing to downgrade:
Fixes #54.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.