Skip to content

Code Submission Procedure

‪Yarin Shlafir‬‏ edited this page Nov 20, 2018 · 6 revisions

Each submission of code should follow the following procedure:

  • git pull - to be synced to the most recant branch
  • Writing the code of the change
  • Writing some passing tests for each non-trivial change
  • Make sure that there are no warnings, and that all the tests pass
  • Spartanize the code
  • Reformat the code (Ctrl+Shift+f)
  • Cleanup the code (Source > Cleanup... with our cleanup profile)
  • Make sure the tests pass after the spartanization and the reformatting
  • git add .
  • Write a commit with a descriptive text, mentioning the corresponding issue.
  • pit pull - to see if there are any merging issues
    • Fix merge issues
  • git push

If you think you closed an issue by your commit please request a code review

And you've submitted a change - Wipiii!