Skip to content

Conversation

@GeorgeBlackwell
Copy link
Contributor

JIRA link

HEEDLS-778

Description

A few changes have been made to Course delegates to make way for the new precursor page that has been added. The changes include removing the side-nav, updating the breadcrumbs and removing the export all button.

Screenshots

image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@GeorgeBlackwell GeorgeBlackwell changed the title add breadcrumbs & remove export all/side nav HEEDLS-778 : Course Delegates - Update course delegates to slot in Delegate Groups Mar 10, 2022
Copy link
Contributor

@livzorn livzorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one missed thing to resolve

@GeorgeBlackwell GeorgeBlackwell merged commit 59b6acd into master Mar 11, 2022
@GeorgeBlackwell GeorgeBlackwell deleted the HEEDLS-778-Update-Course-Delegates branch March 11, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants