DLSV2-517 Include NominatedSupervisors in the Manage Supervisors pick supervisor list #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwhitt-hee
requested changes
Mar 22, 2022
...Solutions.Data/DataServices/SelfAssessmentDataService/SelfAssessmentSupervisorDataService.cs
Outdated
Show resolved
Hide resolved
…uested in PR comments)
|
Please resolve conflicts in the data service. |
…SV2-517-IncludeNominatedInManageSupervisors
…isorDataService's method GetOtherSupervisorsForCandidate. Taking my branch's version of the method, except any reference to sd.Confirmed since that column was recently removed in master.
kevwhitt-hee
approved these changes
Mar 29, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-517-IncludeNominatedInManageSupervisors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include NominatedSupervisors in the Manage Supervisors pick supervisor list
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-517
Description
Updated query in SelfAssessmentSupervisorDataService.cs for including nominated supervisors in "activity supervisors" list and active admins in "quick add".
Also generated RoleName in the query. Not sure if that's needed. Despite
RoleNamehad a hardcoded "Supervisor" value in the original code, it seems ManageSupervisors.cshtml displayssupervisor.RoleNamefrom table SelfAssessmentSupervisorRoles.Screenshots
Developer checks
Checked that nominated supervisors are included on the "activity supervisors" list.