Skip to content

Conversation

@DanBloxham-sw
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw commented Mar 21, 2022

…roke them.

JIRA link

N/A

Description

A branch was merged into master that converted the appsettings connection strings to be different from the required "localhost". The PR that broke it: https://github.com/TechnologyEnhancedLearning/DLSV2/pull/996/files . This prevented both Test and local environments from running. This PR fixes it.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@DanBloxham-sw DanBloxham-sw merged commit 39fddff into master Mar 21, 2022
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-NONE-FixAppsettingsConnectionStrings branch March 21, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants