DLSV2-474 Add warning if sign-off took place prior to changed self-assessment results #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rior to changed self-assessment results
…x method wouldn't throw error
kevwhitt-hee
requested changes
Mar 22, 2022
DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/CompetencyDataService.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning to the sign-off area if sign-off took place prior to changed self-assessment results
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-474
Description
Checked if there are new results in
SelfAssessmentResultsafter self assessment was signed off inCandidateAssessmentSupervisorVerifications.Screenshots
Developer checks
max()method to throw exception when attempting to find maximum value from an empty collection