Skip to content

Conversation

@DanBloxham-sw
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw commented Mar 22, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-621

Description

Fixed the Staff List return page issue for the removal confirmation page, but the link to the page is strangely set up and will point to a bad action when the user has no self assessments.
Fixed the course delegates page by modifying the JS to take query in a whitelisted query parameter and preserve any that match.
Have not been able to fix the screen reader issue.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@GeorgeBlackwell GeorgeBlackwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 Just a minor comment

Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, just the other comment to resolve

@DanBloxham-sw DanBloxham-sw merged commit fae714f into master Mar 23, 2022
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-621-ReturnPageFixes branch March 23, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants