Skip to content

Conversation

@kevwhitt-hee
Copy link
Contributor

JIRA link

DLSV2-541

Description

Fixes a bug with the Frameworks add contributor function. The data service method for retrieving info about the chosen administrator referred to a column (FrameworkCollaborators.Active) that wasn't present.

This method also relies on the email address matching a registered admin user but failed quietly if there wasn't one. This change introduces a validator error message to the page explaining why they weren't added.

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee merged commit 87ceaf2 into master Apr 8, 2022
@kevwhitt-hee kevwhitt-hee deleted the Fix/DLSV2-541-AddFrameworkContributorBug branch April 8, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants