Skip to content

Conversation

@LukeJStuart
Copy link
Contributor

JIRA link

HEEDLS-871

Description

Added ApplicationWithSections model to store application details as well as all of the relevant sections that will be needed for the courses display. Added a new section service to get all sections with tutorials for a given application and return the tutorials as well as the sections. Added new course data services to get applications by brand ID and to get the total numbers of recent progress records for each application for a given brand. Used these in a new course service to return a collection of ApplicationWithSections populated with all details necessary for population of the courses section of the learning content page. Added placeholder content to view to display course cards - sorting, filtering, and pagination has not yet been implemented.

Screenshots

Tables do not format properly on mobile or tablet in Chrome developer mode - this needs to be addressed. Below is a screenshot for desktop.
localhost_5001_LearningContent_1 (4)


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@SteveJacksonSoft
Copy link
Contributor

Very neat code, nice to read!

@AlexJacksonDS AlexJacksonDS force-pushed the HEEDLS-871-Learning_Content_Brand_Courses_Section branch from 59aa65e to 38bbc2c Compare April 22, 2022 12:43
@AlexJacksonDS
Copy link
Contributor

Updated screenshots:
image
image
image

Copy link
Contributor

@GeorgeBlackwell GeorgeBlackwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a couple of redundant using statements

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I've covered everything, number of small points and questions.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a few question to check that everything works as we expect.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good I think.

@AlexJacksonDS AlexJacksonDS merged commit 02749a7 into master Apr 29, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-871-Learning_Content_Brand_Courses_Section branch April 29, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants