-
Notifications
You must be signed in to change notification settings - Fork 1
Heedls 871 learning content brand courses section #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heedls 871 learning content brand courses section #1071
Conversation
DigitalLearningSolutions.Web/DigitalLearningSolutions.Web.csproj
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/Models/Courses/ApplicationWithSections.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CourseDataService.cs
Outdated
Show resolved
Hide resolved
|
Very neat code, nice to read! |
…h to SQL for num recent progress records
…for scenarios with no progress records for some applications
…to tutorial model
… their tutorials rather than an alteration of the existing service and wrote unit tests for new data services and services
… one functioning set of tests
…le and tablet formats and changed heading size
59aa65e to
38bbc2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just a couple of redundant using statements
DigitalLearningSolutions.Web/Scripts/searchSortFilterAndPaginate/sort.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewModels/LearningContent/AllBrandCoursesViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I've covered everything, number of small points and questions.
DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseSetupController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseContentController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CourseDataService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewModels/LearningContent/BrandCourseViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/_BrandCourseCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/searchSortFilterAndPaginate/searchSortFilterAndPaginate.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a few question to check that everything works as we expect.
DigitalLearningSolutions.Data.Tests/Services/CourseServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/_BrandCourseCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/_BrandCourseCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningContent/Index.cshtml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good I think.



JIRA link
HEEDLS-871
Description
Added ApplicationWithSections model to store application details as well as all of the relevant sections that will be needed for the courses display. Added a new section service to get all sections with tutorials for a given application and return the tutorials as well as the sections. Added new course data services to get applications by brand ID and to get the total numbers of recent progress records for each application for a given brand. Used these in a new course service to return a collection of ApplicationWithSections populated with all details necessary for population of the courses section of the learning content page. Added placeholder content to view to display course cards - sorting, filtering, and pagination has not yet been implemented.
Screenshots
Tables do not format properly on mobile or tablet in Chrome developer mode - this needs to be addressed. Below is a screenshot for desktop.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: