DLSV2-536 Move competency description text in self assessment overview to expanders #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overview and supervisor review self assessment to expanders throughout
…me on the generated html page
kevwhitt-hee
requested changes
May 3, 2022
There was a problem hiding this comment.
Please could we use the alternate details expander implementation: https://service-manual.nhs.uk/design-system/components/details instead of nesting the same style expander which looks odd?
DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_OverviewTable.cshtml
Outdated
Show resolved
Hide resolved
kevwhitt-hee
requested changes
May 4, 2022
There was a problem hiding this comment.
See comment in code for reverting styles for group expanders. Also, the change to the supervisor interface is missing. From the ticket:
We should also always use the expanders to show the description on the Web/Supervisor/ReviewSelfAssessment.cshtml page, using the logic:
@if (competency.Description != null)
DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml
Outdated
Show resolved
Hide resolved
daniel-manta-hee
force-pushed
the
Develop/Features/DLSV2-536-MoveCompetencyDescriptionToExpanders
branch
2 times, most recently
from
a8ef647 to
388d3d6
Compare
…nd Details (arrows) for competencies. Prevent error when competency description is null.
…xpanders' of https://github.com/TechnologyEnhancedLearning/DLSV2 into Develop/Features/DLSV2-536-MoveCompetencyDescriptionToExpanders
…ptionToExpanders' of https://github.com/TechnologyEnhancedLearning/DLSV2 into Develop/Features/DLSV2-536-MoveCompetencyDescriptionToExpanders" This reverts commit 196b847, reversing changes made to 42254be.
kevwhitt-hee
requested changes
May 11, 2022
DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_OverviewTable.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_OverviewTable.cshtml
Outdated
Show resolved
Hide resolved
kevwhitt-hee
deleted the
Develop/Features/DLSV2-536-MoveCompetencyDescriptionToExpanders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the competency description text in the self assessment overview and supervisor review self assessment to expanders throughout.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-536
Description
Used same approach applied on ReviewSelfAssessment.cshtml. Added css rules to prevent issue with open and closed icon on the expanders since there are nested expanders and css was confusing parent and child levels.
More details
Before my changes, css was checking for any parent
.nhsuk-expanderthat has anopenattribute. If found, the childnhsuk-details__summary-textdisplays an "open" icon. Problem is, if parent is open, it also displayed open icon for child. Confusing parent with child as it's not designed to work with nested expanders. Existing css rules came from a packagehttps://localhost:44363/node_modules/nhsuk-frontend/packages/components/details/_details.scsslines 154 and 196.Screenshots
AlwaysShowDescriptionset to true.AlwaysShowDescriptionset to false.Developer checks
Checked a list of groups containing some capabilities with AlwaysShowDescription set to true and others set to false.