Skip to content

Conversation

@wahedakhanam
Copy link

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-546

Description

excluding all existing supervisors for the activity and only list each supervisor once.

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@wahedakhanam wahedakhanam requested a review from kevwhitt-hee May 17, 2022 11:00
Removing methods that were removed from this class since this branch was created.
@kevwhitt-hee kevwhitt-hee merged commit 033e28d into master May 17, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-546 branch May 17, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants