HEEDLS-904 Hopefully fix Jenkins pipeline (again)

[simonbrent]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-904

Description

The Jenkins pipeline failed when running Deploy to test: https://jenkins2.softwire.com/job/HEE/job/HEE%20DLS/job/master/1265/console

This commit hopefully fixes that stage of the pipeline, as well as Deploy to UAT. It also switches to using yarn install --frozen-lockfile in both those circumstances.

Note: there is no way to be sure that this will work without merging this PR.

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[DanBloxham-sw]

I suspect this is suitable. I've added a minor comment about testing this prior to merging (provided I've understood the issue correctly).

[DanBloxham-sw]

For what it is worth, you can probably try the Deploy To Test step before merging into master. I think if you just change the branch 'master' above on line 79 to branch '{BranchName}' then the Deploy to Test step will run when you push to that branch.

Obviously, you'd need change it back to master before you merge this.

[simonbrent]

Thanks, I'm trying that out now

[simonbrent]

That worked (https://jenkins2.softwire.com/job/HEE/job/HEE%20DLS/job/HEEDLS-904-fix-jenkins-pipeline/2/console), force-pushing the commit off the branch