Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

…hanged on our environments

JIRA link

HEEDLS-XXXX

Description

Fix a unit test so that it doesn't check a value that we update on our test environment databases

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Reminder to get this on uar-test as well.

@AlexJacksonDS AlexJacksonDS merged commit 8a97ae4 into master Jun 7, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-NONE-update-config-unit-test branch June 7, 2022 13:58
Copy link
Contributor

@simonbrent simonbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants