Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Jun 15, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-925

Description

Add new MultiPageFormData table for use instead of temp data where the temp data is larger than the allowed size. Use this for the Add Course, Admin Fields, and Registration Fields journeys.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@AlexJacksonDS AlexJacksonDS force-pushed the HEEDLS-925-temp-data-to-database-fix branch from b1c0b50 to 28cf100 Compare June 16, 2022 16:31
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlexJacksonDS AlexJacksonDS merged commit b2f56cb into master Jun 21, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-925-temp-data-to-database-fix branch June 21, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants