- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Heedls 925 temp data to database fix #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    simonbrent
  
              
              suggested changes
              
                  
                    Jun 16, 2022 
                  
              
              
            
            
        
          
                DigitalLearningSolutions.Data.Migrations/202206131339_AddMultipageFormDataTable.cs
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/MultiPageFormDataDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/MultiPageFormDataDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/Enums/MultiPageFormDataFeature.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web.AutomatedUiTests/SeleniumServerFactory.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web.AutomatedUiTests/TestFixtures/AccessibilityTestsFixture.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ....Tests/Controllers/TrackingSystem/Centre/Configuration/RegistrationPromptsControllerTests.cs
          
            Show resolved
            Hide resolved
        
              
          
                ....Tests/Controllers/TrackingSystem/Centre/Configuration/RegistrationPromptsControllerTests.cs
          
            Show resolved
            Hide resolved
        
              
          
                ...ningSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseSetupControllerTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      b1c0b50    to
    28cf100      
    Compare
  
    
              
                    SteveJacksonSoft
  
              
              suggested changes
              
                  
                    Jun 17, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
        
          
                DigitalLearningSolutions.Data/Models/MultiPageFormData/AddAdminField/AddAdminFieldData.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/Models/MultiPageFormData/AddNewCentreCourse/CourseTutorialData.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/ServiceFilter/RedirectMissingMultiPageFormData.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/AdminFieldsController.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseSetupController.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/DataServices/MultiPageFormDataServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/DataServices/MultiPageFormDataServiceTests.cs
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/Models/MultiPageFormData/AddNewCentreCourse/SectionContentData.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/Services/MultiPageFormServiceTests.cs
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/Services/MultiPageFormServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    SteveJacksonSoft
  
              
              approved these changes
              
                  
                    Jun 21, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-925
Description
Add new MultiPageFormData table for use instead of temp data where the temp data is larger than the allowed size. Use this for the Add Course, Admin Fields, and Registration Fields journeys.
Screenshots
Attach screenshots on mobile, tablet and desktop.
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: