DLSV2-523 Add flagging of competencies and display in supervisor and self assessment views #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n self assessment
…n self assessment
…be injected into learning portal controller
…lected (checked) when the competency was created or edited
kevwhitt-hee
changed the title
kevwhitt-hee
requested changes
Jun 16, 2022
| <tr role="row" class="nhsuk-table__row first-row"> | ||
| <td role="cell" rowspan="@competency.AssessmentQuestions.Count()" class="nhsuk-table__cell"> | ||
| <td role="cell" rowspan="@competency.AssessmentQuestions.Count()" class="nhsuk-table__cell"> | ||
| <partial name="_ComperencyFlags" model="competency.CompetencyFlags" /> |
There was a problem hiding this comment.
When rendered here, the flag container could do with nhsuk-u-padding-left-4 class adding so that they align with the competency beneath them, which is indented from the left:
There was a problem hiding this comment.
Added new commit.
…escription set to false, so they look in line with other items grouped under same flags
kevwhitt-hee
approved these changes
Jun 21, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-523-FlaggingOfCompetencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flagging of competencies and display in supervisor and self assessment views.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-523
Description
Added migration, updated views, controllers and tests.
Screenshots
Framework Details tab
https://localhost:44363/Framework/2072/Details
Framework custom flags
https://localhost:44363/Frameworks/Flags/2072
Add custom flag
https://localhost:44363/Frameworks/Flags/New/2072
Edit custom flag
https://localhost:44363/Frameworks/Flags/Edit/2072/1012
Add/Edit custom flag validation
Remove Custom flag
https://localhost:44363/Frameworks/Flags/Delete/2072/1012
Edit competency
https://localhost:44363/Frameworks/2072/Competency/1167/1743
Framework competency preview
https://localhost:44363/Frameworks/2072/Competency/1167/1743/Preview
Framework structure interface
https://localhost:44363/Framework/2072/Structure/1167#fc-1743
Self assessment interface
https://localhost:44363/LearningPortal/SelfAssessment/1/Capabilities
Self assessment competency view/review
https://localhost:44363/LearningPortal/SelfAssessment/1/1
Supervisor interface
https://localhost:44363/Supervisor/Staff/2007/ProfileAssessment/1/Review
Developer checks
I have checked: