DLSV2-561 Filter self assessment competencies by flag #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwhitt-hee
approved these changes
Jun 30, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-561-FilterSelfAssessmentCompetenciesByFlag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-561
Description
The dropdown of filters was reworked to allow any integer value instead of being restricted to values in the enum
SelfAssessmentCompetencyFilter. The enum is still being used in the code to identify requirement filters and response filters by their negative values. If positive, the flag filter represents a flagId on table CompetencyFilters. This change only affects the dropdown, as the view itself still usesAppliedFilterViewModelobject. Also created helper classCompetencyFilterHelperto organise the code.Screenshots
Developer checks
Tried multiple combinations of searches for texts with requirements filters, response filters and competency flag filters. Ran searches from Learning Portal application while edit the items from the Framework application.
https://localhost:44363/LearningPortal/SelfAssessment/1/Capabilities
https://localhost:44363/Framework/2/Details