DLSV2-535 Show results awaiting verification with Resend and Withdraw links #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Withdraw actions in the Request Confirmation view
…visor verifications table
kevwhitt-hee
requested changes
Aug 2, 2022
There was a problem hiding this comment.
This looks pretty close to what's needed. I've made some comments in code where tweaks are required.
Also, we need to show all outstanding requests rather than just those than are more than 1 week old.
Ideally we should load the EmailSent date from the SelfAssessmentResultSupervisorVerifications table for each request and only display the "Resend" link if the email was sent more than 1 hour ago. Resending should also update the EmailSent field for the SelfAssessmentResultSupervisorVerifications record. This will prevent users from spamming people with email requests.
...LearningSolutions.Web/Views/LearningPortal/SelfAssessments/ReviewConfirmationRequests.cshtml
Outdated
Show resolved
Hide resolved
...LearningSolutions.Web/Views/LearningPortal/SelfAssessments/VerificationPickSupervisor.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
… retrieved and shown
daniel-manta-hee
force-pushed
the
Develop/Features/DLSV2-535-ShowViewOfResultsAwaitingVerification
branch
from
8be41cf to
de401aa
Compare
…SV2-535-ShowViewOfResultsAwaitingVerification
kevwhitt-hee
requested changes
Aug 9, 2022
DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/_OverviewActionButtons.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| var competencies = PopulateCompetencyLevelDescriptors( | ||
| selfAssessmentService.GetResultSupervisorVerifications(selfAssessmentId, User.GetCandidateIdKnownNotNull()).ToList() |
There was a problem hiding this comment.
This returns an empty list of competencies (count == 0) for a self assessment that definitely has results that are awaiting confirmation.
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
Outdated
Show resolved
Hide resolved
kevwhitt-hee
requested changes
Aug 9, 2022
...LearningSolutions.Web/Views/LearningPortal/SelfAssessments/ReviewConfirmationRequests.cshtml
Outdated
Show resolved
Hide resolved
...LearningSolutions.Web/Views/LearningPortal/SelfAssessments/ReviewConfirmationRequests.cshtml
Outdated
Show resolved
Hide resolved
…ted in comments for PR 1300
kevwhitt-hee
approved these changes
Aug 15, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-535-ShowViewOfResultsAwaitingVerification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show view of results awaiting verification with resend and withdraw actions in the Request confirmation view.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-535
Description
Created
ReviewConfirmationRequests.cshtmland inserted it in the request confirmation gateway as shown on below image. Also added all the logics required for resending and withdrawing requests.Verification confirmation request flow:
Note: controller action methods returning each view are typically named as the view.
Relevant tables for database queries are:
Screenshots
Developer checks
Checked that:
-New confirmation request button, leads to first stage in the request verification gateway.
SelfAssessmentResultSupervisorVerifications.