DLSV2-604 When adding new supervisor, TempDataKey should be used for checking existing session #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new supervisor,
TempDataKeyshould be used for checking existing session.JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-604
Description
MultiPageFormService.cs uses
feature.TempDataKeyas key to find session in database. Attempting to passfeatureinstead offeature.TempDataKeywould result in session not found and causes a redirection to "You don't have permission" page (http 403 forbidden).Screenshots
https://localhost:44363/LearningPortal/SelfAssessment/1/Supervisors
Developer checks
TempData[MultiPageFormDataFeatureis used instead ofTempData[MultiPageFormDataFeature.TempDataKeycausing similar error in other parts of the application