Skip to content

Conversation

@manishagarwalnhs
Copy link
Contributor

@manishagarwalnhs manishagarwalnhs commented Aug 18, 2022

JIRA link

DLSV2-614

Description

In Supervisor → My Staff → Review Self Assessment where a self assessment has a sign off request, reviewing the sign-off request loads some HTML from db, when it does, this text is displayed as plain text with HTML tags instead of as HTML

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee merged commit ae1660a into master Aug 18, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-614 branch August 18, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants