Heedls 1038 reinstate archived courses #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 18, 2022 15:45
SteveJacksonSoft
suggested changes
Aug 19, 2022
| $@"{selectDelegateCourseInfoQuery} | ||
| WHERE pr.CandidateID = @delegateId | ||
| AND ap.ArchivedDate IS NULL | ||
| --AND ap.ArchivedDate IS NULL |
There was a problem hiding this comment.
Commented out code - can you remove?
There was a problem hiding this comment.
This is actually something that slipped past my notice due to how I relied on the Rider syntax highlighting. I'll just check whether this one really wants to be removed (the one below does because it searches by progressId directly).
There was a problem hiding this comment.
It goes to the ViewDelegateController, so I'll remove it.
| $@"{selectDelegateCourseInfoQuery} | ||
| WHERE pr.ProgressID = @progressId | ||
| AND ap.ArchivedDate IS NULL | ||
| --AND ap.ArchivedDate IS NULL |
There was a problem hiding this comment.
Commented out code - can you remove?
| ); | ||
| } | ||
|
|
||
| public IEnumerable<CourseStatisticsWithAdminFieldResponseCounts> |
There was a problem hiding this comment.
This can be private
SteveJacksonSoft
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
HEEDLS-1038
Description
A number of methods have been changed to no longer exclude Archived courses. Some methods have been split into exclusionary and non-exclusionary versions. Only endpoints associated with the CourseSetup section of the Tracking System should exclude archived courses. Methods addressing a specific customisation or progress entry by ID should not exclude archived courses regardless of section. This ticket only pertains to the Tracking System.
Screenshots
N/A
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: