DLSV2-523 Fixes bug: flag checkboxes missing when user enters invalid competency name #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid competency name, less than three characters
kevwhitt-hee
approved these changes
Aug 25, 2022
kevwhitt-hee
deleted the
Develop/Fixes/DLSV2-523-FlaggingOfCompetencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag checkboxes are missing when user enters invalid competency name e.g. less than three characters.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-523
Description
When errors are detected and the model is not valid, still need to retrieve competency flags from the database. In addition, if the user has selected any flag by clicking on the checkboxes, we need to keep selected flags so the user doesn't have to select flags again after amending other errors.
Screenshots
Developer checks
Check that flags no longer missing when competency name is too short and they preserve selected flags when posted back