DLSV2-538 Add clear button for competency questions #1382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to fix a bug reported in Jira ticket comment. There was a previous PR for developing this functionality and it's already merged.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-538
Description
Made changes for inserting null result value on table
SelfAssessmentResultswhen user clears previous assessment question result.More details
Since queries already handle null results to cover a scenario where no result was yet provided, this would have less impact than inserting zeroes (e.g. sql
AVG()ignores null values). After performing aleft join, result would be null in both cases (no result ever provided or null result was inserted). Main difference between no result and a null result, is that resultidis still a number if we have inserted a null result. Tried to find a scenario where this could be an issue among all these queries. But they seem to look for maxIDwhich returns nullResultin both cases (either no matches inSelfAssessmentResultsor a match with nullResult).Screenshots
https://localhost:44363/LearningPortal/SelfAssessment/1/23
Developer checks