Skip to content

Conversation

@daniel-manta-hee
Copy link
Contributor

This pull request is intended to fix a bug reported in Jira ticket comment. There was a previous PR for developing this functionality and it's already merged.

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-538

Description

Made changes for inserting null result value on table SelfAssessmentResults when user clears previous assessment question result.

More details

Since queries already handle null results to cover a scenario where no result was yet provided, this would have less impact than inserting zeroes (e.g. sql AVG() ignores null values). After performing a left join, result would be null in both cases (no result ever provided or null result was inserted). Main difference between no result and a null result, is that result id is still a number if we have inserted a null result. Tried to find a scenario where this could be an issue among all these queries. But they seem to look for max ID which returns null Result in both cases (either no matches in SelfAssessmentResults or a match with null Result).

Screenshots

https://localhost:44363/LearningPortal/SelfAssessment/1/23

image


Developer checks

  • Checked null result is saved and retrieved correctly when user is completing selfassessments at the Learning Portal.
  • Checked Export functionality handles null result and this overrides previous results.

…option is selected as result for an assessment question
…o option is selected as result for an assessment question
@kevwhitt-hee kevwhitt-hee merged commit 886ab7d into master Sep 2, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Features/538-AddClearButtonForCompetencyQuestions branch September 2, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants