Skip to content

Conversation

@manishagarwalnhs
Copy link
Contributor

@manishagarwalnhs manishagarwalnhs commented Sep 7, 2022

JIRA link

DLSV2-621

Description

The competency excel is made read only and password protected. If the user tries to unprotect the workbook, a password need to be entered which the user would not have.

Screenshots

Provided in the jira; https://hee-dls.atlassian.net/browse/DLSV2-621


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working very well. There are a couple of tweaks to get rid of isProtected nullability suggested and then this is ready to go.

@kevwhitt-hee kevwhitt-hee merged commit e0a4eae into master Sep 8, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-621 branch September 8, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants