Skip to content

Conversation

@manishagarwalnhs
Copy link
Contributor

@manishagarwalnhs manishagarwalnhs commented Sep 7, 2022

…esources) results in page not found error

JIRA link

DLSV2-636

Description

A valid route for ungrouped competency was missing i.e. FrameworkCompetencyGroupId is returned as null and there was no route to handle this condition. Note that though FrameworkCompetencyGroupId is present in the route but never used by the action method. The route could be modified to remove FrameworkCompetencyGroupId but the existing code has been left as is.

Screenshots

Screenshots provided in the jira; https://hee-dls.atlassian.net/browse/DLSV2-636


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be working well (though it's hard to review in here because of all of the whitespace changes). Running the code, I notice that the count of resources on the Framework -> Structure page for ungrouped competencies remains 0 after adding competencies:
image
This is after adding a resource so the count should be 1.
Please could we address this, too?

@kevwhitt-hee kevwhitt-hee merged commit 6fc0700 into master Sep 12, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-636 branch September 12, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants