Skip to content

Conversation

@martinfoster-hee
Copy link
Contributor

JIRA link

https://hee-dls.atlassian.net/jira/software/projects/DLSV2/boards/1?assignee=6321797ece3e476e42ac8a00&selectedIssue=DLSV2-646

Description

Updated search signposting resource page to display pagination controls at the top of the search results panel.
Also fixed issue where entering a new search term was retaining the previous search current page rather than resetting to the first page.

Screenshots

Screenshots of both fixes attached.


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

new_top_pagination_toolbar
first_page_reload_on_new_search_term_1of2
first_page_reload_on_new_search_term_2of2

@kevwhitt-hee kevwhitt-hee merged commit c472bc3 into master Sep 30, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/DLSV2-646-FrameworkResourcePaginationRenderingIssues branch September 30, 2022 06:58
@martinfoster-hee martinfoster-hee restored the Develop/Fixes/DLSV2-646-FrameworkResourcePaginationRenderingIssues branch October 4, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants